Allow SlackClient rtm_connect exceptions to be raised #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SlackClient method rtm_connect does not provide a reason for
failed connections and only returns True or False. This change
makes it so:
- Exceptions can be raised in the client's rtm_connect method
- A connection can be established on instantiation
For example, this exception can now be raised so the problem is not
masked:
urllib2.HTTPError: HTTP Error 429: Too Many Requests
The slack client can now be instantiated in this manner:
sc = SlackClient(SLACK_TOKEN, connect=True)
Exceptions can also be raised by invoking rtm_connect as such:
sc.rtm_connect(debug=True)