Skip to content

Conversation

@benoitlavigne
Copy link
Contributor

Summary

Edit to the comment describing the 3 minutes RTM's reconnect logic
Edit to the error message thrown after 5 rate limited connection attempts to the RTM

Requirements (place an x in each [ ])

minor edits to comment and error message when raising error.
@codecov
Copy link

codecov bot commented Mar 27, 2018

Codecov Report

Merging #308 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #308   +/-   ##
=======================================
  Coverage   74.33%   74.33%           
=======================================
  Files          10       10           
  Lines         378      378           
  Branches       67       67           
=======================================
  Hits          281      281           
  Misses         88       88           
  Partials        9        9
Impacted Files Coverage Δ
slackclient/server.py 85.79% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5900610...e5ec333. Read the comment docs.

@Roach Roach merged commit 36cecfa into slackapi:master Mar 27, 2018
lavabyrd pushed a commit that referenced this pull request Apr 25, 2019
minor edits to comment and error message when raising error.
c-goosen pushed a commit to c-goosen/python-slackclient that referenced this pull request Jun 18, 2019
minor edits to comment and error message when raising error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants