Skip to content

Conversation

@Roach
Copy link
Contributor

@Roach Roach commented Aug 23, 2017

Summary

Revert #209

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Aug 23, 2017

Codecov Report

Merging #212 into master will increase coverage by 0.07%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   61.76%   61.84%   +0.07%     
==========================================
  Files           9        9              
  Lines         306      304       -2     
  Branches       57       56       -1     
==========================================
- Hits          189      188       -1     
+ Misses        103      102       -1     
  Partials       14       14
Impacted Files Coverage Δ
slackclient/server.py 61.86% <37.5%> (+0.19%) ⬆️
slackclient/client.py 38.88% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d2fa8c...4042401. Read the comment docs.

@Roach Roach merged commit d83bb74 into master Aug 23, 2017
@Roach Roach deleted the roach/revert_209 branch September 14, 2017 19:21
c-goosen pushed a commit to c-goosen/python-slackclient that referenced this pull request Jun 18, 2019
* Reverting slackapi#209

* Rebuilt docs to remove 'rtm.connect' references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants