Skip to content

Conversation

@acaire
Copy link
Contributor

@acaire acaire commented Mar 8, 2017

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferably).
  • I've written tests to cover the new code and functionality included in this PR.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

@acaire acaire mentioned this pull request Mar 8, 2017
6 tasks
@codecov
Copy link

codecov bot commented Mar 8, 2017

Codecov Report

Merging #173 into master will decrease coverage by 0.25%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
- Coverage   59.87%   59.62%   -0.26%     
==========================================
  Files           9        9              
  Lines         314      317       +3     
  Branches       57       58       +1     
==========================================
+ Hits          188      189       +1     
- Misses        112      113       +1     
- Partials       14       15       +1
Impacted Files Coverage Δ
slackclient/user.py 68.18% <100%> (+1.51%) ⬆️
slackclient/server.py 58.77% <60%> (-0.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51b7fa1...9ba8f28. Read the comment docs.

@Roach Roach self-assigned this Jun 7, 2017
@acaire
Copy link
Contributor Author

acaire commented Oct 19, 2017

@Roach, anything I can do to help move this along? :)

@Roach Roach mentioned this pull request Nov 16, 2017
2 tasks
@Roach Roach merged commit 3ccd408 into slackapi:master Nov 16, 2017
@Roach Roach mentioned this pull request Nov 22, 2017
2 tasks
lavabyrd pushed a commit that referenced this pull request Apr 25, 2019
c-goosen pushed a commit to c-goosen/python-slackclient that referenced this pull request Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants