Skip to content

Conversation

@WilliamBergamin
Copy link
Contributor

This PR reverts #1594 in order to unblock potential future releases.

A potential bug was identified by @HTSagara in a comment on #1594. This was luckily brought up before a new version of the python-slack-sdk was released preventing users from being affected 💯 🥇

The changes introduced by #1594 are available in the issue-#1541 branch, please commit further changes to this branch 🙏

@WilliamBergamin WilliamBergamin added the bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented label Nov 19, 2024
@WilliamBergamin WilliamBergamin self-assigned this Nov 19, 2024
@codecov
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.92%. Comparing base (c82c9a0) to head (0c91f8b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1597   +/-   ##
=======================================
  Coverage   84.92%   84.92%           
=======================================
  Files         113      113           
  Lines       12628    12622    -6     
=======================================
- Hits        10724    10719    -5     
+ Misses       1904     1903    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@WilliamBergamin WilliamBergamin merged commit a5b9db6 into main Nov 19, 2024
11 checks passed
@WilliamBergamin WilliamBergamin deleted the revert-1594-issue-#1541 branch November 19, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants