Skip to content

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Nov 28, 2022

Summary

This pull request resolves #1304

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x socket-mode labels Nov 28, 2022
@seratch seratch added this to the 3.19.5 milestone Nov 28, 2022
@seratch seratch self-assigned this Nov 28, 2022
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #1307 (3598bcd) into main (f2f3fd6) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1307      +/-   ##
==========================================
+ Coverage   85.79%   85.80%   +0.01%     
==========================================
  Files          84       84              
  Lines        7861     7861              
==========================================
+ Hits         6744     6745       +1     
+ Misses       1117     1116       -1     
Impacted Files Coverage Δ
slack_sdk/socket_mode/aiohttp/__init__.py 81.34% <ø> (ø)
slack_sdk/socket_mode/builtin/internals.py 72.53% <0.00%> (+0.42%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit 937bf94 into slackapi:main Nov 28, 2022
@seratch seratch deleted the issue-1304-ssl-for-async-socket-mode branch November 28, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented socket-mode Version: 3x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ssl_context is not passed from async web_client to aiohttp socket client

1 participant