Skip to content

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Nov 15, 2022

Summary

This pull request resolves #1297

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

…ss objects for chat.unfurl API call fails
@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client Version: 3x labels Nov 15, 2022
@seratch seratch added this to the 3.19.4 milestone Nov 15, 2022
@seratch seratch self-assigned this Nov 15, 2022
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #1301 (d417dc9) into main (3610592) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1301      +/-   ##
==========================================
- Coverage   85.79%   85.78%   -0.02%     
==========================================
  Files          84       84              
  Lines        7845     7846       +1     
==========================================
  Hits         6731     6731              
- Misses       1114     1115       +1     
Impacted Files Coverage Δ
slack_sdk/web/legacy_client.py 83.26% <100.00%> (+0.01%) ⬆️
slack_sdk/socket_mode/builtin/internals.py 72.10% <0.00%> (-0.43%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch
Copy link
Contributor Author

seratch commented Nov 16, 2022

Thanks for the review!

@seratch seratch merged commit 9e0fa3d into slackapi:main Nov 16, 2022
@seratch seratch deleted the issue-1297-user_auth_blocks branch November 16, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x web-client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Building user_auth_blocks with slack_sdk.models class objects for chat.unfurl API call fails

2 participants