Skip to content

Conversation

@taekop
Copy link
Contributor

@taekop taekop commented Oct 24, 2022

Summary

Simply fix type hint for selected_option parameter

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2022

CLA assistant check
All committers have signed the CLA.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client Version: 3x labels Oct 24, 2022
@seratch seratch added this to the 3.19.2 milestone Oct 24, 2022
@seratch seratch self-assigned this Oct 24, 2022
Copy link
Contributor

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #1281 (874920b) into main (3fda85a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1281   +/-   ##
=======================================
  Coverage   85.63%   85.63%           
=======================================
  Files          84       84           
  Lines        7826     7826           
=======================================
  Hits         6702     6702           
  Misses       1124     1124           
Impacted Files Coverage Δ
slack_sdk/models/views/__init__.py 92.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit f47f5cc into slackapi:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x web-client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants