Skip to content

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Sep 29, 2022

Summary

To align with slackapi/java-slack-sdk#1059, this pull request adds the missing argument to conversations_replies method.

see also: https://api.slack.com/methods/conversations.replies

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@seratch seratch added enhancement M-T: A feature request for new functionality web-client Version: 3x labels Sep 29, 2022
@seratch seratch added this to the 3.18.4 milestone Sep 29, 2022
@seratch seratch self-assigned this Sep 29, 2022
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #1270 (25f8817) into main (0782f56) will decrease coverage by 0.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1270      +/-   ##
==========================================
- Coverage   86.64%   86.14%   -0.50%     
==========================================
  Files         111       84      -27     
  Lines       11027     7773    -3254     
==========================================
- Hits         9554     6696    -2858     
+ Misses       1473     1077     -396     
Impacted Files Coverage Δ
slack_sdk/web/legacy_client.py 86.24% <ø> (ø)
slack_sdk/web/async_client.py
slack_sdk/web/client.py
slack_sdk/oauth/__init__.py
slack_sdk/web/base_client.py
slack_sdk/signature/__init__.py
slack_sdk/scim/__init__.py
slack_sdk/socket_mode/__init__.py
slack_sdk/webhook/async_client.py
slack_sdk/web/async_slack_response.py
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple clean fix 💯 looks good to me

@filmaj filmaj merged commit 411d107 into slackapi:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality Version: 3x web-client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants