Skip to content

Conversation

@rei-0
Copy link
Contributor

@rei-0 rei-0 commented Sep 18, 2022

Summary

New TimePicker element is not supported in the ViewStateValue class. See issue #1265

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2022

CLA assistant check
All committers have signed the CLA.

@seratch
Copy link
Contributor

seratch commented Sep 18, 2022

@rei-0 Thanks for sending this fix! Would you mind signing the CLA? Without it, we are unable to merge any external contributions. It’d be appreciated if you could understand this.

@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client Version: 3x labels Sep 18, 2022
@seratch seratch added this to the 3.18.4 milestone Sep 18, 2022
@seratch seratch self-assigned this Sep 18, 2022
@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #1266 (11fe1e0) into main (e239b16) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1266   +/-   ##
=======================================
  Coverage   86.65%   86.66%           
=======================================
  Files         111      111           
  Lines       11026    11027    +1     
=======================================
+ Hits         9555     9556    +1     
  Misses       1471     1471           
Impacted Files Coverage Δ
slack_sdk/models/views/__init__.py 92.00% <100.00%> (+0.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rei-0
Copy link
Contributor Author

rei-0 commented Sep 18, 2022

@seratch Signed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 3x web-client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants