Remove Dead Link From Readme #1034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi Slackers, I noticed that there was a dead anchor link in the readme table of contents for RTM client documentation. I understand RTM is deprecated (in favor of "socket mode") and a prior PR understandably deleted the introductory RTM documentation from the readme - slackapi#807. However, it seems this lone dead link to to the now-deleted content was left behind. My PR removes the dead link so nobody is confused trying to click it, like I was. :) Thanks!
seratch
added
docs
Contributor
|
@personalcomputer Thanks for taking the time to make this PR! Already looks great to me but I will merge it once the CI builds pass. |
Codecov Report
@@ Coverage Diff @@
## main #1034 +/- ##
==========================================
+ Coverage 84.34% 84.37% +0.03%
==========================================
Files 95 95
Lines 8878 8878
==========================================
+ Hits 7488 7491 +3
+ Misses 1390 1387 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hi Slack developers!
I noticed that there was a dead anchor link in the readme table of contents for RTM client documentation. I understand RTM is not especially promoted (in favor of socket mode) and a prior PR understandably deleted the introductory RTM documentation from the readme. However, it seems this lone dead link to to the now-deleted content was left behind. My PR removes the dead link so nobody is confused trying to click it, like I was. :)
Thanks!
Category (place an
xin each of the[ ])/docs-src(Documents, have you run./docs.sh?)/docs-src-v2(Documents, have you run./docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python setup.py validateafter making the changes.