Skip to content

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Jun 5, 2021

Summary

This pull request adds missing properties in the Audit Logs API response classes.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.models (UI component builders)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.rtm (RTM client)
  • slack_sdk.signature (Request Signature Verifier)
  • /docs-src (Documents, have you run ./docs.sh?)
  • /docs-src-v2 (Documents, have you run ./docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python setup.py validate after making the changes.

@seratch seratch added enhancement M-T: A feature request for new functionality Version: 3x audit-logs-client labels Jun 5, 2021
@seratch seratch added this to the 3.7.0 milestone Jun 5, 2021
@codecov
Copy link

codecov bot commented Jun 5, 2021

Codecov Report

Merging #1029 (56dab4d) into main (15551b5) will increase coverage by 0.67%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1029      +/-   ##
==========================================
+ Coverage   83.66%   84.34%   +0.67%     
==========================================
  Files          95       95              
  Lines        8792     8880      +88     
==========================================
+ Hits         7356     7490     +134     
+ Misses       1436     1390      -46     
Impacted Files Coverage Δ
slack_sdk/audit_logs/v1/logs.py 100.00% <100.00%> (+22.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15551b5...56dab4d. Read the comment docs.

@seratch seratch merged commit 0a7918a into slackapi:main Jun 7, 2021
@seratch seratch deleted the audit-logs-updates branch June 7, 2021 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audit-logs-client enhancement M-T: A feature request for new functionality Version: 3x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant