Skip to content

Fix #1025 websocket_client based SocketModeClient may fail in on_close callback #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seratch merged 2 commits into from
May 28, 2021
Merged

Fix #1025 websocket_client based SocketModeClient may fail in on_close callback #1026

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec20407
Fix #1025 websocket_client based SocketModeClient may fail in on_clos…
seratch May 28, 2021
2bff457
Merge branch 'main' into issue-1025-websocket_client_on_close
seratch May 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions slack_sdk/socket_mode/websocket_client/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,15 @@ def on_error(ws: WebSocketApp, error: Exception):
for listener in self.on_error_listeners:
listener(ws, error)

def on_close(ws: WebSocketApp):
def on_close(
ws: WebSocketApp,
close_status_code: Optional[int] = None,
close_msg: Optional[str] = None,
):
if self.logger.level <= logging.DEBUG:
self.logger.debug("on_close invoked")
self.logger.debug(
f"on_close invoked: (code: {close_status_code}, message: {close_msg})"
)
if self.auto_reconnect_enabled:
self.logger.info("Received CLOSE event. Going to reconnect...")
self.connect_to_new_endpoint()
Expand Down