Skip to content

feat: implement check update hook#8

Merged
WilliamBergamin merged 16 commits intomainfrom
add-check-update-hooks
Jan 4, 2024
Merged

feat: implement check update hook#8
WilliamBergamin merged 16 commits intomainfrom
add-check-update-hooks

Conversation

@WilliamBergamin
Copy link
Contributor

Summary

This PR aim to introduce the implementation of the check-update hook

Testing

  1. follow the instructions in the readme in order to create and app
  2. run slack update
    a. Their should be no errors and nothing to update
  3. run pip install pip install slack-sdk==3.25.0
  4. run slack update
    a. The CLI should inform you that and update for slack_sdk is available

Special notes

Areas of feedback:

  • code cleanliness
  • approach
  • should we include other fields to return to the CLI

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_and_run_tests.sh after making the changes.

@WilliamBergamin WilliamBergamin added the enhancement New feature or request label Dec 21, 2023
@WilliamBergamin WilliamBergamin self-assigned this Dec 21, 2023
WilliamBergamin and others added 3 commits January 3, 2024 12:49
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
@WilliamBergamin WilliamBergamin merged commit efed2b0 into main Jan 4, 2024
@WilliamBergamin WilliamBergamin deleted the add-check-update-hooks branch January 4, 2024 19:27
@WilliamBergamin WilliamBergamin changed the title [feat] implement check update hook feat: implement check update hook Jan 11, 2024
@WilliamBergamin
Copy link
Contributor Author

This resolves #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants