fix: introduce the packaging dependency#39
Merged
WilliamBergamin merged 1 commit intomainfrom Apr 16, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
=======================================
Coverage 94.58% 94.58%
=======================================
Files 11 11
Lines 203 203
=======================================
Hits 192 192
Misses 11 11 ☔ View full report in Codecov by Sentry. |
zimeg
approved these changes
Apr 15, 2024
Member
zimeg
left a comment
There was a problem hiding this comment.
🐣 Awesome! The slack update is working wonderfully for me now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to resolve #29 where the
packagingdependency is not installed on the system.It seems like
pipwhich uses thepackagingproject duplicates the logic into its source code rather then installing it as a dependency. Seems like the chicken and egg problem 🥚This PR aims to introduce
packagingas a dependency to the project, alternatively we could duplicate the logic likepipdoes, or find another solution rather then adding our first "real" dependencyTesting
slack create -t https://github.com/slack-samples/bolt-python-custom-function-templaterequirements.txtfile so that it only contains (many other packages have thepackagingdependency)slack updateSpecial notes
Important to not that many python development tools like
pip,blackandpytestuse thepackagingproject, this is why we did not catch this error soonerRequirements
./scripts/install_and_run_tests.shafter making the changes.