Merged
Conversation
WilliamBergamin
added
enhancement
zimeg
approved these changes
Mar 28, 2024
Member
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
LGTM! I'm a huge fan of this automation!
Comment on lines
+120
to
+122
| Releases for this library are automatically generated off of git releases. Before | ||
| creating a new release, ensure that everything on a feature branch, | ||
| [run the tests](#run-all-the-unit-tests). |
Member
There was a problem hiding this comment.
The wording is a little confusing here- not super sure what should be on the feature branch 😜
Contributor
Author
There was a problem hiding this comment.
Good point I'll change this to stable branch?
Member
There was a problem hiding this comment.
Either stable or feature would be good IMO. I was poking more at if we want to make sure "everything on a x branch has landed, then run the tests" or something else?
seratch
approved these changes
Mar 29, 2024
Contributor
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
Thanks, looks good to me
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to automate the release process of the project. Creating a GitHub release will kick off a GitHub action that releases a new version of this project to pypi.
Testing
I've tested the build flow on my fork
Special notes
The automation flow follows what is implemented by the deno sdk
Review of the maintainers guide PR is greatly appreciated
Requirements
./scripts/install_and_run_tests.shafter making the changes.