socket-mode(fix): do not handle message events twice #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filmaj
added
bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2059 +/- ##
=======================================
Coverage 91.74% 91.74%
=======================================
Files 38 38
Lines 10081 10081
Branches 631 631
=======================================
Hits 9249 9249
Misses 820 820
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. |
zimeg
approved these changes
Oct 2, 2024
Comment on lines
+269
to
+270
| client.on('message', spy); | ||
| client.emit('ws_message', message, false /* isBinary */); |
There was a problem hiding this comment.
Wow! 😳 What a find!! 🔍 ✨
Edit: Argh should've included the surrounding spy for context but I cannot edit the lines commented on 😐
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2057 uncovered that the socket mode client was raising errors when parsing
messageSlack events. Turns out this was due to the fact that the Socket Mode client was listening on both Slackmessageevents as well as thewspackage'smessageevent. When a web socket message would come in, the client would re-emit the event'stypeas a new message to be bubbled up. In the case of Slackmessageevents, this would effectively mean they would be processed twice.Fixes #2057.