Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (web-api / types): Add support for assistant.threads.* API #2033

Merged
merged 6 commits into from
Sep 17, 2024

Conversation

misscoded
Copy link
Contributor

Summary

Adds support for assistant.threads.* endpoints, including:

Requirements (place an x in each [ ])

@misscoded misscoded added enhancement M-T: A feature request for new functionality pkg:web-api applies to `@slack/web-api` pkg:types applies to `@slack/types` labels Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.51%. Comparing base (0c1ceb5) to head (2bfcfa3).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2033      +/-   ##
==========================================
+ Coverage   92.48%   92.51%   +0.02%     
==========================================
  Files          37       37              
  Lines        9946     9981      +35     
  Branches      633      633              
==========================================
+ Hits         9199     9234      +35     
  Misses        747      747              
Flag Coverage Δ
cli-hooks 95.23% <ø> (ø)
cli-test 96.00% <ø> (ø)
oauth 81.52% <ø> (ø)
socket-mode 59.08% <ø> (ø)
web-api 97.29% <100.00%> (+0.01%) ⬆️
webhook 97.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@ -0,0 +1,29 @@
export interface AssistantThreadStartedEvent {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filmaj These are used in the implementation for Bolt, but figured they should go in now. Let me know if you prefer these to be separate!

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one suggestion re: factoring out a type and specifying "at least 1" (if applicable).

As for the formatting, I recently changed the linter (#2006), and I don't think I re-ran generating the response types since then. @misscoded can you try resetting your node_modules folder and running the lint task locally? rm -rf node_modules package-lock.json && npm it. I have a feeling that will fix the response types and tighten up the diff in this PR.

packages/web-api/src/types/request/assistant.ts Outdated Show resolved Hide resolved
@misscoded misscoded merged commit 571bc3a into main Sep 17, 2024
30 checks passed
@misscoded misscoded deleted the feat-app-assistant branch September 17, 2024 18:12
@misscoded misscoded modified the milestones: types@2.14.0, web-api@7.5.0 Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality pkg:types applies to `@slack/types` pkg:web-api applies to `@slack/web-api`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants