Skip to content

Conversation

@filmaj
Copy link
Contributor

@filmaj filmaj commented Oct 7, 2024

FYI @seratch & @WilliamBergamin

We will need to add support soon for this API: https://api.slack.com/methods/conversations.requestSharedInvite.list

This closely relates to #1365

This document shows the necessary requirements in terms of Slack plan (enterprise grid) and settings (specific enterprise Slack Connect settings): https://api.slack.com/automation/governing-slack-connect-invites

Once you have the above set up, then when a non-admin / non-owner user (this part tripped me up!) sends a Slack Connect invite, you can use the list API to then list out these to-be-approved SC invites. I tested this out by having a regular grid user open up a channel's settings -> Settings tab -> Slack Connect invite.

@seratch this PR is definitely insufficient to add support for this API to the java SDK - my apologies. When I have a moment, I will review past PRs that added new APIs to this repo and copy the approach. If you have any additional pointers for this, let me know and I can address it tomorrow. In the mean time, this PR at least unblocks me from getting a PR for this API ready in the node-slack-sdk repo. EDIT: I've added some more to this PR but I am still missing the ListResponse class; since the response structure is a bit more complicated than the simple cases, I am not sure how to exactly proceed - your guidance would be appreciated. Feel free to push to this PR if it's something you can address directly easier, too.

@filmaj filmaj self-assigned this Oct 7, 2024
@codecov
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.55%. Comparing base (11e46d0) to head (353521f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...java/com/slack/api/methods/RequestFormBuilder.java 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1382      +/-   ##
============================================
+ Coverage     74.52%   74.55%   +0.02%     
- Complexity     4324     4329       +5     
============================================
  Files           472      472              
  Lines         13491    13506      +15     
  Branches       1377     1378       +1     
============================================
+ Hits          10054    10069      +15     
+ Misses         2624     2623       -1     
- Partials        813      814       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch added enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client labels Oct 8, 2024
@seratch seratch added this to the 1.44.0 milestone Oct 8, 2024
@seratch seratch force-pushed the shared-invite-list-sample branch from e6c0ee2 to 353521f Compare October 8, 2024 01:25
@seratch
Copy link
Contributor

seratch commented Oct 8, 2024

@filmaj Thanks for working on this! I've completed the remaining changes and needed adjustment!

@seratch seratch merged commit be30886 into main Oct 8, 2024
@seratch seratch deleted the shared-invite-list-sample branch October 8, 2024 01:33
@seratch seratch changed the title adding conversations.requestSharedInvite.list response sample log Add conversations.requestSharedInvite.list API support Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants