Skip to content

Speedup slow tests due to rate limit #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seratch merged 1 commit into from
Sep 19, 2024
Merged

Speedup slow tests due to rate limit #1377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions slack-api-client/src/test/java/test_locally/api/methods/TeamTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,15 @@

import com.slack.api.Slack;
import com.slack.api.SlackConfig;
import com.slack.api.methods.MethodsConfig;
import com.slack.api.methods.MethodsCustomRateLimitResolver;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import util.MockSlackApiServer;

import java.util.Optional;

import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.MatcherAssert.assertThat;
import static util.MockSlackApi.ValidToken;
Expand All @@ -21,6 +25,19 @@ public class TeamTest {
public void setup() throws Exception {
server.start();
config.setMethodsEndpointUrlPrefix(server.getMethodsEndpointPrefix());
MethodsConfig methodsConfig = new MethodsConfig();
methodsConfig.setCustomRateLimitResolver(new MethodsCustomRateLimitResolver() {
@Override
public Optional<Integer> getCustomAllowedRequestsPerMinute(String teamId, String methodName) {
return Optional.of(20);
}

@Override
public Optional<Integer> getCustomAllowedRequestsForChatPostMessagePerMinute(String teamId, String channel) {
return Optional.empty();
}
});
config.setMethodsConfig(methodsConfig);
}

@After
Expand Down
16 changes: 16 additions & 0 deletions slack-api-client/src/test/java/test_locally/api/methods_admin_api/AdminApiAsyncTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
import com.slack.api.Slack;
import com.slack.api.SlackConfig;
import com.slack.api.methods.AsyncMethodsClient;
import com.slack.api.methods.MethodsConfig;
import com.slack.api.methods.MethodsCustomRateLimitResolver;
import com.slack.api.model.admin.AppConfig;
import org.junit.After;
import org.junit.Before;
Expand All @@ -11,6 +13,7 @@

import java.lang.reflect.Array;
import java.util.Arrays;
import java.util.Optional;

import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.MatcherAssert.assertThat;
Expand All @@ -26,6 +29,19 @@ public class AdminApiAsyncTest {
public void setup() throws Exception {
server.start();
config.setMethodsEndpointUrlPrefix(server.getMethodsEndpointPrefix());
MethodsConfig methodsConfig = new MethodsConfig();
methodsConfig.setCustomRateLimitResolver(new MethodsCustomRateLimitResolver() {
@Override
public Optional<Integer> getCustomAllowedRequestsPerMinute(String teamId, String methodName) {
return Optional.of(50);
}

@Override
public Optional<Integer> getCustomAllowedRequestsForChatPostMessagePerMinute(String teamId, String channel) {
return Optional.empty();
}
});
config.setMethodsConfig(methodsConfig);
}

@After
Expand Down