-
Notifications
You must be signed in to change notification settings - Fork 228
Add files.upload v2 support #1065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1065 +/- ##
============================================
+ Coverage 76.80% 76.87% +0.07%
- Complexity 3733 3765 +32
============================================
Files 407 409 +2
Lines 11250 11384 +134
Branches 1128 1141 +13
============================================
+ Hits 8640 8752 +112
- Misses 1936 1948 +12
- Partials 674 684 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
WilliamBergamin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, slick work 💯
This pull request adds a new way to upload files to Slack.
The legacy files.upload API endpoint now has severe performance issues as described in the following reports:
Slack platform team decided to unlock a new way to upload files using the following endpoints:
https://files.slack.com/upload/v1/***to upload the file content per fileThis pull request adds supports for the new endpoints, so that now the low-level APIs are available for developers. Having said that, going through the above process for uploading files requires many lines of code on 3rd party app side. Also, following all the steps can be confusing for developers.
For this reason, in addition to the low-level API supports, I propose to add MethodsClient#filesUploadV2 method as a wrapper of the whole file-upload operation. Here are the code examples demonstrating how it works:
Once we agree that we can go with this design, I will add the same one to other SDKs (Node, Python).
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.