Skip to content

Fix #1058 Add include_all_metadata to conversations.replies arguments #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seratch merged 2 commits into from
Sep 27, 2022
Merged

Fix #1058 Add include_all_metadata to conversations.replies arguments #1059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9350bd
Support include_all_metadata argument on the conversations.replies API.
scarytom Sep 27, 2022
0f81693
Merge branch 'main' into include_all_metadata
seratch Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions slack-api-client/src/main/java/com/slack/api/methods/RequestFormBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1446,6 +1446,7 @@ public static FormBody.Builder toForm(ConversationsRepliesRequest req) {
setIfNotNull("channel", req.getChannel(), form);
setIfNotNull("oldest", req.getOldest(), form);
setIfNotNull("latest", req.getLatest(), form);
setIfNotNull("include_all_metadata", req.isIncludeAllMetadata(), form);
return form;
}

Expand Down
5 changes: 5 additions & 0 deletions ...rc/main/java/com/slack/api/methods/request/conversations/ConversationsRepliesRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,9 @@ public class ConversationsRepliesRequest implements SlackApiRequest {
*/
private String latest;

/**
* Return all metadata associated with this message.
*/
private boolean includeAllMetadata;

}
16 changes: 16 additions & 0 deletions slack-api-client/src/test/java/test_with_remote_apis/methods/message_metadata_Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,14 @@
import com.slack.api.Slack;
import com.slack.api.methods.MethodsClient;
import com.slack.api.methods.SlackApiException;
import com.slack.api.methods.request.conversations.ConversationsRepliesRequest;
import com.slack.api.methods.response.chat.ChatDeleteResponse;
import com.slack.api.methods.response.chat.ChatPostMessageResponse;
import com.slack.api.methods.response.chat.ChatScheduleMessageResponse;
import com.slack.api.methods.response.chat.ChatUpdateResponse;
import com.slack.api.methods.response.conversations.ConversationsHistoryResponse;
import com.slack.api.methods.response.conversations.ConversationsListResponse;
import com.slack.api.methods.response.conversations.ConversationsRepliesResponse;
import com.slack.api.model.Conversation;
import com.slack.api.model.Message;
import config.Constants;
Expand Down Expand Up @@ -141,6 +143,20 @@ public void sendAndRead() throws Exception {
assertThat(returnedPayload.get("objects"), is(parsedObjects));
}

ConversationsRepliesResponse replies = client.conversationsReplies(req -> req
.channel(randomChannelId)
.ts(messageWithMetadata.getTs())
.limit(1)
.includeAllMetadata(true)
);
assertThat(replies.getError(), is(nullValue()));
{
Map<String, Object> returnedPayload = replies.getMessages().get(0).getMetadata().getEventPayload();
assertThat(returnedPayload.get("id"), is(messageEventPayload.get("id")));
assertThat(returnedPayload.get("tags"), is(messageEventPayload.get("tags")));
assertThat(returnedPayload.get("objects"), is(parsedObjects));
}

messageEventPayload.put("tags", Arrays.asList("FOO"));
ChatUpdateResponse modification = client.chatUpdate(r -> r
.channel(messageWithMetadata.getChannel())
Expand Down