Skip to content

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Jul 7, 2022

This pull request adds timezone property to timepicker block element. see also: slackapi/node-slack-sdk#1502

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:slack-api-model project:slack-api-model labels Jul 7, 2022
@seratch seratch added this to the 1.23.1 milestone Jul 7, 2022
@seratch seratch self-assigned this Jul 7, 2022
@seratch seratch requested review from WilliamBergamin and filmaj July 7, 2022 05:32
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #1010 (635fcf4) into main (010182c) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #1010      +/-   ##
============================================
- Coverage     76.76%   76.67%   -0.09%     
+ Complexity     3688     3687       -1     
============================================
  Files           403      403              
  Lines         11120    11121       +1     
  Branches       1111     1111              
============================================
- Hits           8536     8527       -9     
- Misses         1909     1922      +13     
+ Partials        675      672       -3     
Impacted Files Coverage Δ
...xtension/block/element/TimePickerElementBuilder.kt 87.50% <0.00%> (-5.84%) ⬇️
...va/com/slack/api/socket_mode/SocketModeClient.java 64.33% <0.00%> (-3.19%) ⬇️
...i/socket_mode/impl/SocketModeClientJavaWSImpl.java 63.81% <0.00%> (-2.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 010182c...635fcf4. Read the comment docs.

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@seratch
Copy link
Contributor Author

seratch commented Jul 7, 2022

Thanks for the review!

@seratch seratch merged commit 6952eef into slackapi:main Jul 7, 2022
@seratch seratch deleted the timezone-in-timepicker branch July 7, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality project:slack-api-model project:slack-api-model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants