Pass the Bolt logger in default WebClient instantiation#246
Merged
seratch merged 1 commit intoslackapi:mainfrom Feb 24, 2021
Merged
Pass the Bolt logger in default WebClient instantiation#246seratch merged 1 commit intoslackapi:mainfrom
seratch merged 1 commit intoslackapi:mainfrom
Conversation
169586d to
2f47812
Compare
2f47812 to
7374d29
Compare
Codecov Report
@@ Coverage Diff @@
## main #246 +/- ##
=======================================
Coverage 91.36% 91.37%
=======================================
Files 160 160
Lines 4971 4973 +2
=======================================
+ Hits 4542 4544 +2
Misses 429 429
Continue to review full report at Codecov.
|
This was referenced Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the consistency of logging in Bolt. Thanks to @eddyg's feedback in the community workspace: https://community.slack.com/archives/CHL4CLRCZ/p1614000712009600 (if you're not a member of the workspace, you can join from here)
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.