chore: improve maintainers docs#1226
Merged
WilliamBergamin merged 4 commits intoslackapi:mainfrom Dec 18, 2024
Merged
Conversation
WilliamBergamin
added
docs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1226 +/- ##
=======================================
Coverage 90.96% 90.96%
=======================================
Files 222 222
Lines 7501 7501
=======================================
Hits 6823 6823
Misses 678 678 ☔ View full report in Codecov by Sentry. |
zimeg
approved these changes
Dec 18, 2024
Member
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
LGTM! These formatting changes make future edits so much quicker - thanks for making this a PR 📚 ✨
I left a few comments and questions that might want to be reviewed before merging, but feel free to merge whenever! 🚢
| - Create a new GitHub Release from the [Releases page](https://github.com/slackapi/bolt-python/releases) by clicking the "Draft a new release" button. | ||
| - Enter the new version number updated from the commit (e.g. `v1.2.3`) into the "Choose a tag" input. | ||
| - Ensure the tag `Target` branch is `main` (e.g `Target:main`). | ||
| - Click the "Create a new tag: x.x.x on publish" button. This won't create your tag immediately. |
Member
There was a problem hiding this comment.
This won't create your tag immediately.
🙏 ✨
Co-authored-by: Eden Zimbelman <zim@o526.net>
Co-authored-by: Eden Zimbelman <zim@o526.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the maintainers documentation and PR template. It update the release instruction to match the python SDK and follow the Deno patterns
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.