Repository navigation
Add Quart framework adapter #619
Description
Activity
@sonnens Thanks for submitting this suggestion!
For others, more information about Quart framework:
Before discussing the details of the implementation of the PR, let me share our policies on the built-in adapters.
- We need unit tests and simple examples for long-term maintenance (I will let you know the details in the PR comment)
- In general, we don't prioritize less popular frameworks (meaning less than 10K downloads per day) for built-in ones
Our rough standard to decide what framework to support is how widely a framework is accepted in the communities. We know that the number of PyPI package downloads is not the only metric representing popularity but we use the data as a criteria for our internal decision. The lowest level of the number for assessing the popularity is 10K per day. All the frameworks currently supported are above 10K (at least, they were above 10K when we decided to support).
According to https://pypistats.org/packages/quart, Quart is downloaded 3.5K times per day as of this month. We have to say that this is not our high priority. If you need this adapter addition as early as possible, we as the maintainers of bolt-python and other Slack SDKs need your or community members' help.
For the above reasons, I will ask you to put more efforts on your pull request. It'd be greatly appreciated if you could understand this.
Hi @sonnens, I've revisited this and found that Quart is now more popular and its download per day is above 13K. If you are still interested in continuing with your PR, we are happy to review it. As I mentioned in the PR, we need unit tests and CI builds for all built-in adapters. Once these are added, your PR will be merged. Let us know what you think 👋
@seratch any update here??
We don’t have immediate plans to add the adapter. If you are in a hurry, please reuse the code in the PR. I haven’t verified but perhaps it works for you. There is no need to wait for a built-in support.
I know this issue is rather old, but https://pypistats.org/packages/quart is showing that Quart has 42,950 downloads in the last day, which is quite a bit above the 10k line.
I'd be happy to contribute to getting this merged but can't commit to more than one-time assistance with that.
want to support the asyncio loop in quart apps