Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: rewind body before reading it. #508

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

dblock
Copy link
Collaborator

@dblock dblock commented Jan 31, 2024

Closes #506.

@coveralls
Copy link

coveralls commented Jan 31, 2024

Pull Request Test Coverage Report for Build 7729093569

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 89.108%

Totals Coverage Status
Change from base Build 7718739724: -0.06%
Covered Lines: 5056
Relevant Lines: 5674

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jan 31, 2024

Pull Request Test Coverage Report for Build 7729511010

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 89.184%

Totals Coverage Status
Change from base Build 7718739724: 0.02%
Covered Lines: 5063
Relevant Lines: 5677

💛 - Coveralls

@dblock dblock merged commit fac7a6a into slack-ruby:master Jan 31, 2024
9 checks passed
@dblock dblock deleted the rack-3.0-rewind branch January 31, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slack::Events::Request#verify! not working with Rack 3
2 participants