Remove websocker-driver dependency #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
blowfishpro
force-pushed
the
RemoveWebsockerDriverDependency
branch
3 times, most recently
from
99b0297
to
c2bd51c
Compare
It appears that this should never have been here - It was required to support some celluloid code, but celluloid was optional anyway, and the celluloid code has since been removed.
blowfishpro
force-pushed
the
RemoveWebsockerDriverDependency
branch
from
c2bd51c
to
a960e16
Compare
|
Merged. Do a quick test on your project, and I'll cut a release this week? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that this should never have been here - It was required to support some celluloid code, but celluloid was optional anyway, and the celluloid code has since been removed.
Resolves #431