Update real_time.rake to remove outdated event hooks and organize alphabetically #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
dblock
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
slack:real_time:api:updatetask currently doesn't touch previous hooks and only prepends new event handler templates at the top of the store. The result is that many of the hooks currently in the stores are for Slack events that no longer exist or have outdated documentation. Additionally, there is no consistent ordering.This PR makes the task more intelligent to extract all the current hooks and reuse only the hooks themselves while always generating fresh documentation and arranging the hooks in alphabetical order. Any hooks not matching the current Slack API ref are discarded.
This sets up updating some hook implementations for changes in #423