Fix exp2, exp10, cube and cube_neg1 sensor conversions #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 / 3 is integer math and evaluates to 0 cube root is equivalent to pow(value, 1.0 / 3.0), not pow(value -1/3)
JJL772
changed the title
JJL772
force-pushed
the
pr-fix-sensor-convs
branch
from
e179386 to
4490b78
Compare
JJL772
force-pushed
the
pr-fix-sensor-convs
branch
from
4490b78 to
19c994f
Compare
marciodo
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed exp2 and exp10 conversions. The
valueand constant parameters were swapped.SENSOR_CONV_CUBEshould be cube, not cube root.SENSOR_CONV_CUBE_NEG1should be cube root. The IPMI spec is not very clear on this, but it defines this conversion asI've also substituted the
powforcbrthere because it is faster thanpow(x, 1.0/3.0)(not that it matters :))This fixes the issues seen with the Vadatech ATC807 switches and their
vOutreadout.