-
Notifications
You must be signed in to change notification settings - Fork 5
Fix linker errors and RELEASE.local for the test IOC #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
marciodo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using extern in variables inside header files doesn't seem right to me. Can you comment more on it? Maybe add the compiler message error that you are getting without it?
|
The IOC specifically fails to build with linker errors. This is due to how static libraries are generated; each translation unit that includes a header containing a variable definition without external or static linkage (i.e. |
|
This is actually a symptom of
The default probably changed since GCC 4.8.5. |
I've been through the same problems and it worked fine with the changes in @JJL772's branch. |
marciodo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run in the test environment and it worked.


Fixes some issues I ran into when building this locally.
Closes #30