show design pattern for removing OFFSET defines - not ready for merge! #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request shows only the design pattern we'll need to use to remove the *_OFFSET defines. It is not intended to be merged, yet.
Removing the offset #defines is as simple as it would seem. The existing structure is for an internal (useful) representation of the data. There should be another struct which is used for marshalling and unmarshalling the data. The marshalling struct has some extra fields we do not care about internally, and the existing useful struct has some extra data that we do care about. So the structs don't overlap perfectly.
It would be nice to find a doc that describes the marshalling structs, if one exists. Then we would have the authoritative definition and we wouldn't have to guess on its structure based on what we see in the #defines.