Skip to content

Conversation

@jpzwarte
Copy link
Member

Fixes #2786

Copilot AI review requested due to automatic review settings October 29, 2025 11:39
@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2025

🦋 Changeset detected

Latest commit: cc3634e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@sl-design-system/icon Patch
@sl-design-system/bingel-dc Patch
@sl-design-system/bingel-int Patch
@sl-design-system/clickedu Patch
@sl-design-system/editorial-suite Patch
@sl-design-system/itslearning Patch
@sl-design-system/kampus Patch
@sl-design-system/magister Patch
@sl-design-system/max Patch
@sl-design-system/my-digital-book Patch
@sl-design-system/myvanin Patch
@sl-design-system/neon Patch
@sl-design-system/sanoma-learning Patch
@sl-design-system/sanoma-utbildning Patch
@sl-design-system/teas Patch
@sl-design-system/tig Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the IconPrefix type definition to make it more flexible and future-proof. Instead of maintaining an exhaustive list of FontAwesome icon prefixes, the type now uses a template literal type that accepts any string starting with "fa".

  • Changed IconPrefix from a union of 37 specific prefix literals to a flexible template literal type fa${string}
  • Updated the comment to clarify the reasoning behind this change

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/components/icon/src/models.ts Replaced exhaustive union type with flexible template literal type for IconPrefix
.changeset/modern-trees-hammer.md Added changeset documenting the patch-level change

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

🕸 Website preview

You can view a preview here (commit cc3634e3ad10512dbe6325ef9416bdd23b053763).

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

🕸 Storybook preview

You can view a preview here (commit cc3634e3ad10512dbe6325ef9416bdd23b053763).

@jpzwarte jpzwarte requested a review from Copilot October 29, 2025 11:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Icon] Change the way we interact with Font Awesome types so they do not break as often

2 participants