Skip to content

Conversation

@jpzwarte
Copy link
Member

Fixes #2645

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2025

🦋 Changeset detected

Latest commit: f2da142

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@sl-design-system/button Minor
@sl-design-system/tooltip Minor
@sl-design-system/tool-bar Patch
@sl-design-system/grid Patch
@sl-design-system/panel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jpzwarte jpzwarte marked this pull request as ready for review September 18, 2025 13:41
@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2025

🕸 Website preview

You can view a preview here (commit f2da142d53b67c9137fb1dbe31e25ca43d8e3935).

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2025

🕸 Storybook preview

You can view a preview here (commit 3008cbaf99e11aaf4f61dc7a6b4d864c40ed2088).

@jpzwarte jpzwarte marked this pull request as draft September 19, 2025 06:53
@jpzwarte jpzwarte marked this pull request as ready for review September 19, 2025 08:34
@Diaan
Copy link
Collaborator

Diaan commented Sep 19, 2025

Can you update the documentation as well? And describe in which cases it is ok/better to use the aria-disabled option?

@jpzwarte jpzwarte merged commit f025c0f into main Sep 19, 2025
10 of 13 checks passed
@jpzwarte jpzwarte deleted the feature/2645-aria-disabled-button branch September 19, 2025 09:36
@github-actions github-actions bot mentioned this pull request Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Button] Add ability for tooltip on disabled buttons

4 participants