Skip to content

Conversation

@anna-lach
Copy link
Collaborator

@anna-lach anna-lach commented Sep 12, 2025

Fixes only missing divider, the rest should be done in a separate issue.

@anna-lach anna-lach linked an issue Sep 12, 2025 that may be closed by this pull request
6 tasks
@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2025

🦋 Changeset detected

Latest commit: d268565

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sl-design-system/listbox Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2025

🕸 Website preview

You can view a preview here (commit d26856558fc87b124e04984672fdcbd874067432).

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2025

🕸 Storybook preview

You can view a preview here (commit d26856558fc87b124e04984672fdcbd874067432).

@anna-lach anna-lach marked this pull request as ready for review September 12, 2025 12:11
@Diaan
Copy link
Collaborator

Diaan commented Sep 15, 2025

Not entirely sure it should be part of this story, but when an option group doesn't have a label the margin/padding is wrong:
image
(compare '😶 Unfazed' with '🐷 Pig')

@anna-lach anna-lach merged commit 6e34fcb into main Sep 15, 2025
13 checks passed
@anna-lach anna-lach deleted the fix/1931-select-option-group-styling-is-not-complete branch September 15, 2025 08:19
@github-actions github-actions bot mentioned this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Select] Option group styling is not complete

4 participants