Skip to content

fix: update font-weight to use semiBold for consistency across compon… #2548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 4, 2025
Merged

fix: update font-weight to use semiBold for consistency across compon… #2548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e8f1fc
fix: update font-weight to use semiBold for consistency across compon…
Diaan Sep 3, 2025
8ebcf6d
fix: update expected column widths in sl-column-group tests because o…
Diaan Sep 3, 2025
9cb61fb
Merge branch 'main' into fix/2523-form-field-form-field-labels-use-re…
Diaan Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .changeset/smart-buttons-switch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
'@sl-design-system/inline-message': patch
'@sl-design-system/message-dialog': patch
'@sl-design-system/calendar': patch
'@sl-design-system/dialog': patch
'@sl-design-system/badge': patch
'@sl-design-system/panel': patch
'@sl-design-system/form': patch
'@sl-design-system/grid': patch
'@sl-design-system/tabs': patch
---

Fixed wrong token for bold font-weight
2 changes: 1 addition & 1 deletion packages/components/badge/src/badge.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export const All: Story = {
${[undefined, 'bold'].map(emphasis =>
colors.map(
color => html`
<span style="font-weight: ${emphasis ? 'var(--sl-text-typeset-fontWeight-demibold)' : 'regular'}">
<span style="font-weight: ${emphasis ? 'var(--sl-text-new-typeset-fontWeight-semiBold)' : 'regular'}">
${color}
</span>
<sl-badge color=${ifDefined(color)} emphasis=${ifDefined(emphasis)} size="sm"></sl-badge>
Expand Down
2 changes: 1 addition & 1 deletion packages/components/calendar/src/select-day.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
.current-month,
.current-year {
font-size: 1.2em;
font-weight: var(--sl-text-typeset-fontWeight-demibold);
font-weight: var(--sl-text-new-typeset-fontWeight-semiBold);

sl-icon {
color: var(--sl-color-foreground-subtlest);
Expand Down
2 changes: 1 addition & 1 deletion packages/components/calendar/src/select-month.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

.current-year {
font-size: 1.2em;
font-weight: var(--sl-text-typeset-fontWeight-demibold);
font-weight: var(--sl-text-new-typeset-fontWeight-semiBold);
margin-inline-end: auto;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/components/calendar/src/select-year.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

.current-range {
font-size: 1.2em;
font-weight: var(--sl-text-typeset-fontWeight-demibold);
font-weight: var(--sl-text-new-typeset-fontWeight-semiBold);
margin-inline-end: auto;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/components/dialog/src/dialog.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ dialog {
slot[name='title'] {
color: var(--sl-color-foreground-bold);
font-size: 1.7em;
font-weight: var(--sl-text-typeset-fontWeight-demibold);
font-weight: var(--sl-text-new-typeset-fontWeight-semiBold);
line-height: 1.42em;

@media (width <= 600px) {
Expand Down
2 changes: 1 addition & 1 deletion packages/components/form/src/error.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
align-items: center;
color: var(--sl-color-foreground-negative-plain);
display: flex;
font-weight: var(--sl-text-typeset-fontWeight-demibold);
font-weight: var(--sl-text-new-typeset-fontWeight-semiBold);
gap: var(--sl-size-050);
padding-block-start: var(--sl-size-050);
}
2 changes: 1 addition & 1 deletion packages/components/form/src/label.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
align-items: center;
color: var(--sl-color-foreground-bold);
display: inline-flex;
font-weight: var(--sl-text-typeset-fontWeight-demibold);
font-weight: var(--sl-text-new-typeset-fontWeight-semiBold);
}

.optional,
Expand Down
5 changes: 3 additions & 2 deletions packages/components/grid/src/column-group.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ describe('sl-column-group', () => {
it('should have the correct width', () => {
const cells = Array.from(el.renderRoot.querySelectorAll('th'));
expect(cells.map(cell => Math.floor(parseFloat(getComputedStyle(cell).width)))).to.deep.equal([
369, 636, 185, 183, 169, 157, 166, 144
374, 631, 188, 186, 166, 158, 166, 141
]);
});
});
Expand Down Expand Up @@ -85,8 +85,9 @@ describe('sl-column-group', () => {

it('should have the correct width when one is set explicitly', () => {
const cells = Array.from(el.renderRoot.querySelectorAll('th'));

expect(cells.map(cell => Math.floor(parseFloat(getComputedStyle(cell).width)))).to.deep.equal([
271, 734, 214, 212, 197, 186, 195
278, 727, 216, 214, 194, 186, 194
]);
});
});
Expand Down
2 changes: 1 addition & 1 deletion packages/components/grid/src/grid.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ th {
}

> span {
font-weight: var(--sl-text-typeset-fontWeight-demibold);
font-weight: var(--sl-text-new-typeset-fontWeight-semiBold);
padding-block: var(--_head-cell-padding-block);
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/components/grid/src/group-header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,6 @@ sl-button {
}

[part='group-heading'] {
font-weight: var(--sl-text-typeset-fontWeight-demibold);
font-weight: var(--sl-text-new-typeset-fontWeight-semiBold);
padding-block: var(--sl-size-125);
}
2 changes: 1 addition & 1 deletion packages/components/grid/src/sorter.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
}

slot {
font-weight: var(--sl-text-typeset-fontWeight-demibold);
font-weight: var(--sl-text-new-typeset-fontWeight-semiBold);
}

sl-button {
Expand Down
2 changes: 1 addition & 1 deletion packages/components/grid/src/stories/styling.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ export const Parts: Story = {
--rating-text-decoration: underline;
}
sl-grid::part(data grades) {
font-weight: var(--sl-text-typeset-fontWeight-demibold);
font-weight: var(--sl-text-new-typeset-fontWeight-semiBold);
text-decoration: var(--rating-text-decoration, none);
}
sl-grid::part(high-grades) {
Expand Down
2 changes: 1 addition & 1 deletion packages/components/inline-message/src/inline-message.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ sl-button {
[part='title'] {
align-self: start;
font-size: 1.2em;
font-weight: var(--sl-text-typeset-fontWeight-demibold);
font-weight: var(--sl-text-new-typeset-fontWeight-semiBold);
grid-area: 1 / 2;
margin-block-end: var(--sl-size-025);

Expand Down
2 changes: 1 addition & 1 deletion packages/components/message-dialog/src/message-dialog.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ dialog {
h1 {
color: var(--sl-color-foreground-bold);
font-size: 1.7em;
font-weight: var(--sl-text-typeset-fontWeight-demibold);
font-weight: var(--sl-text-new-typeset-fontWeight-semiBold);
line-height: 1.42em;
margin-block: 0;
text-box: trim-both cap alphabetic;
Expand Down
2 changes: 1 addition & 1 deletion packages/components/panel/src/panel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ slot[name='heading'],
slot[name='heading']::slotted(*) {
color: var(--sl-color-foreground-bold);
font-size: 1.143em;
font-weight: var(--sl-text-typeset-fontWeight-demibold);
font-weight: var(--sl-text-new-typeset-fontWeight-semiBold);
padding-block: var(--sl-size-100);
}

Expand Down
2 changes: 1 addition & 1 deletion packages/components/tabs/src/tab.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
:host([has-subtitle]) {
slot:not([name]) {
font-size: 1.2em;
font-weight: var(--sl-text-typeset-fontWeight-demibold);
font-weight: var(--sl-text-new-typeset-fontWeight-semiBold);
}

slot[name='subtitle']::slotted(*) {
Expand Down