Skip to content

Conversation

@anna-lach
Copy link
Collaborator

No description provided.

@anna-lach anna-lach linked an issue Aug 13, 2025 that may be closed by this pull request
@changeset-bot
Copy link

changeset-bot bot commented Aug 13, 2025

🦋 Changeset detected

Latest commit: 266fb76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@sl-design-system/combobox Patch
@sl-design-system/menu Patch
@sl-design-system/dialog Patch
@sl-design-system/date-field Patch
@sl-design-system/select Patch
@sl-design-system/popover Patch
@sl-design-system/shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2025

🕸 Website preview

You can view a preview here (commit 266fb768035d52d3083aab5f3083e1fc13449125).

@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2025

🕸 Storybook preview

You can view a preview here (commit 266fb768035d52d3083aab5f3083e1fc13449125).

@anna-lach anna-lach marked this pull request as ready for review August 13, 2025 12:21
@Diaan
Copy link
Collaborator

Diaan commented Aug 19, 2025

Clicking outside both the calendar and the dialog closes both. Is this the interaction we want?
https://github.com/user-attachments/assets/defdf93c-5dba-4af8-8e76-9bb9ce769e0c

I think it should just close the top layer. It should work the same way as the escape button.
If you're filling in a form and you want to cancel filling in the date, then you don't want the whole dialog to close and everything you filled in be gone.

@anna-lach anna-lach marked this pull request as draft August 19, 2025 12:19
@anna-lach anna-lach marked this pull request as ready for review August 27, 2025 08:16
@anna-lach anna-lach merged commit 17fbc40 into main Aug 27, 2025
12 of 13 checks passed
@anna-lach anna-lach deleted the fix/2059-date-field-clicking-a-date-in-a-dialog-can-close-the-dialog branch August 27, 2025 10:09
@github-actions github-actions bot mentioned this pull request Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Date field] Clicking a date in a dialog can close the dialog

4 participants