Skip to content

fix wrong indent #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2023
Merged

fix wrong indent #41

merged 1 commit into from
Feb 23, 2023

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented Feb 23, 2023

解决缩进错误。

捎带测试一下 CI。

@myd7349 myd7349 marked this pull request as ready for review February 23, 2023 09:50
@skywind3000 skywind3000 merged commit 987cd9e into skywind3000:master Feb 23, 2023
@myd7349 myd7349 deleted the fix-indent branch February 23, 2023 11:46
@skywind3000
Copy link
Owner

skywind3000 commented Feb 23, 2023

我测试过了,MinGW 和 VC 编译出来的版本都可以在 Win7 下面正确运行,先都保留吧,用一段时间看看。

@skywind3000
Copy link
Owner

ci 有个小问题,生成的打包里面的版本号都叫做 v1.0.6,是没有拉到最新版本呢?还是纯粹一个命名问题?

这下面的我手工改了:

https://github.com/skywind3000/PyStand/releases/tag/1.0.8

这下面的还没改,你可以看到版本号错误现场:

https://github.com/skywind3000/PyStand/releases/tag/1.0.7

@skywind3000
Copy link
Owner

skywind3000 commented Feb 23, 2023

好像是 build.yml 开头的宏决定的?对应代码肯定是当前打 tag 的代码?

对了,能不能把所有 binary 放到一个 zip 里?比如 PyStand-v1.0.8-exe.zip 里面,里面分目录放就行。

每个版本所有可执行在一个包里的话,用着方便点,不用全部解压,拖出需要的即可,另外是
给 Windows Defender 报 false positive 的时候也方便一次性提交多个可执行:

https://www.microsoft.com/en-us/wdsi/filesubmission

Windows Defender 太激进了,查毒技术不行就来个宁可错杀不肯放过,
我经常会到 Windows Defender 那里报一个 false positive,这样就不会报毒了。

@myd7349
Copy link
Contributor Author

myd7349 commented Feb 24, 2023

ci 有个小问题,生成的打包里面的版本号都叫做 v1.0.6,是没有拉到最新版本呢?还是纯粹一个命名问题?

纯粹命名问题。

好像是 build.yml 开头的宏决定的?对应代码肯定是当前打 tag 的代码?

嗯。是的。最初的想法是每次发布新版本之前都手动 bump 一下那个版本号 -> 打 Tag -> push,现在看起来实操不方便。

PYSTAND_VERSION 仅在文件名里用到了,拉取代码都用的是 HEAD 版本的代码。

晚上优化一下,自动从 Tag 获取版本号。

对了,能不能把所有 binary 放到一个 zip 里?比如 PyStand-v1.0.8-exe.zip 里面,里面分目录放就行。

好的。我晚上改一下。

@skywind3000
Copy link
Owner

那每次提交时我手工改一下 PYSTAND_VERSION 就行,问题不大。

@myd7349 myd7349 mentioned this pull request Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants