-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyPI config and instruction #999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will take a closer look in a bit
pyproject.toml
Outdated
description = "An intercloud broker above the cloud" | ||
readme = "README.md" | ||
license = { file="LICENSE" } | ||
requires-python = ">=3.6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we require < 3.10 explicitly in our docs, is there some way we can specify it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking more about it, this article provides very good arguments for not capping the version. Maybe we can let it be unless we have a strong dependency on <3.10?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, good discussion! I think the only dependency for <3.10 is our current ray==1.10.0. The problem should be fixed by #969.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @Michaelvll!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we hold off on merging this until after OSS? For example the docs URL may need changes.
Sure, I will not merge the PR before OSS. |
Removed some duplications and try to test it on pypi, we can now download Skypilot from https://pypi.org/project/skypilot/
Please try it out and take another look : ). I will wait for #1010 before publishing our |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice @Michaelvll, some minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @Michaelvll !
Thank you for the reviews @concretevitamin @romilbhardwaj ! Merging this PR, after passed the smoke tests. Will create a release for 0.1.1 soon. ; ) |
Add configuration file and instruction for publishing our project to Pypi.
Tested:
pip install skypilot
,python -c "import sky; sky.echo()"
(echo is the only function I put in the placeholder PyPi package).