Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPI config and instruction #999

Merged
merged 42 commits into from
Aug 8, 2022
Merged

PyPI config and instruction #999

merged 42 commits into from
Aug 8, 2022

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Jul 20, 2022

Add configuration file and instruction for publishing our project to Pypi.

Tested:

  • pip install skypilot, python -c "import sky; sky.echo()" (echo is the only function I put in the placeholder PyPi package).

Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take a closer look in a bit

pyproject.toml Show resolved Hide resolved
.github/workflows/yapf.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
pyproject.toml Outdated
description = "An intercloud broker above the cloud"
readme = "README.md"
license = { file="LICENSE" }
requires-python = ">=3.6"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we require < 3.10 explicitly in our docs, is there some way we can specify it here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking more about it, this article provides very good arguments for not capping the version. Maybe we can let it be unless we have a strong dependency on <3.10?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, good discussion! I think the only dependency for <3.10 is our current ray==1.10.0. The problem should be fixed by #969.

@concretevitamin concretevitamin self-requested a review July 21, 2022 03:09
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Michaelvll!

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we hold off on merging this until after OSS? For example the docs URL may need changes.

.github/workflows/yapf.yml Show resolved Hide resolved
.style.yapf Show resolved Hide resolved
@Michaelvll
Copy link
Collaborator Author

Can we hold off on merging this until after OSS? For example the docs URL may need changes.

Sure, I will not merge the PR before OSS.

@Michaelvll Michaelvll added the blocked PR blocked by other issues label Jul 25, 2022
@Michaelvll Michaelvll removed the blocked PR blocked by other issues label Jul 28, 2022
@Michaelvll
Copy link
Collaborator Author

Michaelvll commented Jul 28, 2022

Removed some duplications and try to test it on pypi, we can now download Skypilot from https://pypi.org/project/skypilot/

pip install skypilot[aws]==0.0.2
sky status

Please try it out and take another look : ). I will wait for #1010 before publishing our skypilot==0.1.0 so that our readme on the pypi will be up-to-date.

Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @Michaelvll, some minor comments.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
sky/setup_files/setup.py Show resolved Hide resolved
sky/setup_files/setup.py Show resolved Hide resolved
sky/setup_files/setup.py Outdated Show resolved Hide resolved
sky/setup_files/setup.py Show resolved Hide resolved
Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @Michaelvll !

sky/setup_files/setup.py Outdated Show resolved Hide resolved
@Michaelvll Michaelvll changed the title Pypi config and instruction PyPI config and instruction Jul 29, 2022
@Michaelvll
Copy link
Collaborator Author

Michaelvll commented Aug 8, 2022

Thank you for the reviews @concretevitamin @romilbhardwaj ! Merging this PR, after passed the smoke tests. Will create a release for 0.1.1 soon. ; )

@Michaelvll Michaelvll merged commit bccc512 into master Aug 8, 2022
@Michaelvll Michaelvll deleted the pypi branch August 8, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants