Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unnecessary ssh hanging issue on Ray #851

Merged
merged 6 commits into from
Oct 25, 2022
Merged

Fix unnecessary ssh hanging issue on Ray #851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aa4e348
Fix ray hanging ssh issue
infwinston May 18, 2022
93ba8e7
Fix
infwinston May 18, 2022
1874d01
change the order back
infwinston May 18, 2022
7f49dbe
Update node status after first attempt
infwinston Jun 5, 2022
052e52d
Merge branch 'master' into fix-ray-autoscaler-ssh
infwinston Jun 8, 2022
f4d190c
Merge branch 'master' into fix-ray-autoscaler-ssh
infwinston Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sky/skylet/ray_patches/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,9 @@ def patch() -> None:
_run_patch(resource_demand_scheduler.__file__,
_to_absolute('resource_demand_scheduler.py.patch'))

from ray.autoscaler._private import updater
_run_patch(updater.__file__, _to_absolute('updater.py.patch'))

# Fix the Azure get-access-token (used by ray azure node_provider) timeout issue,
# by increasing the timeout.
# Tracked in https://github.com/Azure/azure-cli/issues/20404#issuecomment-1249575110
Expand Down
7 changes: 7 additions & 0 deletions sky/skylet/ray_patches/updater.py.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
0a1,4
> # From https://github.com/ray-project/ray/blob/releases/2.0.1/python/ray/autoscaler/_private/updater.py
> # Sky patch changes:
> # - Ensure the node state is refreshed before checking the node is terminated.
>
318a319
> self.provider.non_terminated_nodes({})