[Core] Remove unnecessary k8s handling in sky check and add tests
#7412
+353
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-625
to
-652
| if cloud_name == repr(sky_clouds.Kubernetes()): | ||
| # Get enabled contexts for Kubernetes | ||
| existing_contexts = sky_clouds.Kubernetes.existing_allowed_contexts() | ||
| if not existing_contexts: | ||
| return _green_color(cloud_and_capabilities) | ||
|
|
||
| # Check if allowed_contexts is explicitly set in config | ||
| allowed_contexts = skypilot_config.get_effective_region_config( | ||
| cloud='kubernetes', | ||
| region=None, | ||
| keys=('allowed_contexts',), | ||
| default_value=None) | ||
|
|
||
| # Format the context info with consistent styling | ||
| if allowed_contexts is not None: | ||
| contexts_formatted = [] | ||
| for i, context in enumerate(existing_contexts): | ||
| symbol = (ux_utils.INDENT_LAST_SYMBOL | ||
| if i == len(existing_contexts) - | ||
| 1 else ux_utils.INDENT_SYMBOL) | ||
| contexts_formatted.append(f'\n {symbol}{context}') | ||
| context_info = f' Allowed contexts:{"".join(contexts_formatted)}' | ||
| else: | ||
| context_info = f' Active context: {existing_contexts[0]}' | ||
|
|
||
| return (f'{_green_color(cloud_and_capabilities)}\n' | ||
| f' {colorama.Style.DIM}{context_info}' | ||
| f'{colorama.Style.RESET_ALL}') |
There was a problem hiding this comment.
oh wow I just realized this never gets run because of L621-623
SeungjinYang
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)