Skip to content

Torchtitan example updates #7400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 29, 2025
Merged

Torchtitan example updates #7400

merged 17 commits into from
Sep 29, 2025

Conversation

alex000kim
Copy link
Contributor

  • Update docs/source/generate_examples.py to scan subdirs two levels deep
  • Add more focus in examples/training/torchtitan/README.md on distributed training, auto-recovery and scalability

Michaelvll
Michaelvll reviewed Sep 26, 2025
View reviewed changes
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alex000kim! Left some comments.

alex000kim and others added 10 commits September 27, 2025 08:46
@alex000kim @Michaelvll
Update examples/training/torchtitan/README.md
9af8ec6 
Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>
@alex000kim @Michaelvll
Update examples/training/torchtitan/README.md
cefbd2a 
Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>
@alex000kim @Michaelvll
Update examples/training/torchtitan/README.md
380ad5b 
Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>
@alex000kim @Michaelvll
Update examples/training/torchtitan/README.md
aaf66fe 
Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>
@alex000kim @Michaelvll
Apply suggestion from @Michaelvll
4beec5b 
Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>
@alex000kim @Michaelvll
Apply suggestion from @Michaelvll
a5923e8 
Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>
@alex000kim @Michaelvll
Apply suggestion from @Michaelvll
0b6616e 
Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>
@alex000kim
address comments
7474f42
@alex000kim
address comments
0036b7d
@alex000kim
update
cef09c3
Michaelvll
Michaelvll reviewed Sep 29, 2025
View reviewed changes
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alex000kim! Some additional comments.

alex000kim and others added 4 commits September 29, 2025 13:22
@alex000kim @Michaelvll
Update examples/training/torchtitan/README.md
5e2ea15 
Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>
@alex000kim @Michaelvll
Update examples/training/torchtitan/README.md
cae08ad 
Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>
@alex000kim
update
304daf9
@alex000kim
update cluster name
80d6f61
Michaelvll
Michaelvll approved these changes Sep 29, 2025
View reviewed changes
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alex000kim! Let's merge it first : )

@Michaelvll Michaelvll merged commit 96e3061 into skypilot-org:master Sep 29, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michaelvll Michaelvll Michaelvll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex000kim @Michaelvll