[k8s][examples] rdvz fix for k8s and Llama 4 example #5960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romilbhardwaj
commented
Jun 11, 2025
| pod_uuid = str(uuid.uuid4())[:6] | ||
| pod_name = f'{cluster_name_on_cloud}-{pod_uuid}' | ||
| pod_spec_copy['metadata']['name'] = f'{pod_name}-worker' | ||
| pod_name = f'{cluster_name_on_cloud}-worker{i}' |
There was a problem hiding this comment.
This may raise some back compat concerns, need to verify
There was a problem hiding this comment.
Manually tested backcompat with sky exec, sky launch and sky status -r. Since we filter based on labels and not pod names, backward compatibility is unaffected.
|
/smoke-test --kubernetes |
|
/quicktest-core --kubernetes |
|
/smoke-test --kubernetes |
|
Smoke tests failures unrelated to PR:
Rest of the tests seem to pass. This should be good to go. |
SeungjinYang
force-pushed
the
k8s-rdvz-fix
branch
from
c56695a to
5bbc89f
Compare
SeungjinYang
approved these changes
Jun 24, 2025
|
/smoke-test --kubernetes -k test_cancel_launch_and_exec_async |
|
/smoke-test --kubernetes -k test_skyserve_fast_update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4140 and adds an example for training llama 4 maverick (400B MoE). The example needed a fix for rdvz on k8s, inspired by #3800.