-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serve] Update log pattern in _follow_replica_logs
for new UX 3.0
#4333
Conversation
…to centralized `log_utils.follow_logs`
@cblmemo PTAL, thanks! |
c8af397
to
da8548d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also run smoke tests to make sure we are not broking anything. sky-serve related one is enough
@cblmemo PTAL, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls also make sure the smoke test is passed. Noticed that serve tests is somehow flacky. After it passed it should be good to go!
Blocked by #4323
Update log file patterns used by
_follow_replica_logs
to match new UX 3.0 output format introduced in #4023.The old patterns were matching
tail -n100 -f
which is no longer present in the new UX.Tested (run the relevant ones):
bash format.sh
sky serve logs new-http 1
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
conda deactivate; bash -i tests/backward_compatibility_tests.sh
FYK, here are the logs I recorded:
Logs