-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DigitalOcean] droplet integration #3832
base: master
Are you sure you want to change the base?
Conversation
@asaiacai I would be really interested in using this work -- do you know when you might be able to land this PR? |
Hello! I’m aiming for this to land in next two weeks providing testing goes
smoothly. Stay tuned!
|
@Michaelvll i think this PR is finally ready, once you have a free moment! I've currently disabled tests for gpu droplets as they are still in early access, but I think I got the remaining tests to work on normal CPU droplets fine. Let me know if you find any issues. |
also this catalog update is required to pass the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this amazing work @asaiacai ! This would be very helpful. Left some discussions ;)
Co-authored-by: Tian Xia <cblmemo@gmail.com>
Co-authored-by: Tian Xia <cblmemo@gmail.com>
@cblmemo reran smoke, but if you have a moment to review again, thanks in advance! |
@cblmemo digital ocean released a new image for AI/ML with docker. It's a lot more bloated than the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @asaiacai for this amazing contribution! Looks mostly good to me. After those nits get resolved and smoke test passed, it should be ready to go!
@pytest.mark.do | ||
def test_do_job_queue_with_docker(generic_cloud: str, image_id: str): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to reuse the previous function and add another argument for accelerator to use? same for other tests in this file. You can checkout @pytest.mark.parametrize
Co-authored-by: Tian Xia <cblmemo@gmail.com>
Co-authored-by: Tian Xia <cblmemo@gmail.com>
Co-authored-by: Tian Xia <cblmemo@gmail.com>
Co-authored-by: Tian Xia <cblmemo@gmail.com>
This adds digital ocean droplets to the sky.
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py --do