[Core] Task level config #3689
Merged
[Core] Task level config #3689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cblmemo
reviewed
Jul 5, 2024
There was a problem hiding this comment.
Thanks for adding this feature @Michaelvll ! Left some comments to discuss :)
| resources_config = config.pop('resources', {}) | ||
| if cluster_config_override is not None: | ||
| assert resources_config.get('_cluster_config_overrides') is None, ( | ||
| 'Cannot set _cluster_config_overrides in both resources and ' |
There was a problem hiding this comment.
Should we raise an error if we find user specified resources._cluster_config_overrides as this is not allowed (according to the comment in the schema)?
There was a problem hiding this comment.
We currently rely on the same API to check the YAML provided by the user and the YAML generated by SkyPilot internally. It may require some refactoring, and it may not be very urgent to do such check as we do not expose this field in our docs. : )
There was a problem hiding this comment.
Good point! Lets keep the current one
cblmemo
approved these changes
Jul 9, 2024
5 tasks
Michaelvll
added a commit
that referenced
this pull request
Aug 23, 2024
* Add docker run options * Add docs * Add warning for docker run options in kubernetes * Add experimental config * fix * rename vars * type * format * wip * rename and add tests * Fixes and add tests * format * Assert for override configs specification * format * Add comments * fix * fix assertions * fix assertions * Fix test * fix * remove unsupported keys * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow task-level configuration.
Blocked by #3682Tested (run the relevant ones):
bash format.shpytest tests/test_config.pypytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_nameconda deactivate; bash -i tests/backward_compatibility_tests.sh