Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8s] Add skypilot-user label to pods #3576

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

romilbhardwaj
Copy link
Collaborator

Adds skypilot-user label to pods to help with observability.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • Manually with sky launch and kubectl describe pod
    • Adhoc smoke tests pytest tests/test_smoke.py::test_autodown --kubernetes
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@romilbhardwaj romilbhardwaj merged commit 89e8d48 into master May 22, 2024
20 checks passed
@romilbhardwaj romilbhardwaj deleted the k8s_skypilotuser branch May 22, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants