-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Command runner refactor and avoid source ~/.bashrc
for better speed
#3484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into kubernetes-runner
… into kubernetes-runner
cblmemo
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It looks mostly good to me. Left several nits and it should ready to go after smoke test 🫡
Co-authored-by: Tian Xia <cblmemo@gmail.com>
Co-authored-by: Tian Xia <cblmemo@gmail.com>
…pilot into command-runner-refactor
…pilot into command-runner-refactor
…d-runner-refactor
…d-runner-refactor
Tested (65001c8):
|
…d-runner-refactor
…d-runner-refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated from #3157.
Compared to master (8a18133)
Launching new clusters
GCP (new provisioner)
Master: (145+130+163+127+145)/5 = 142s = 2m22s
This PR: (134+123+132+134+142)/5 = 133 = 2m13s (-9s)
Azure (ray autoscaler)
Master: (514 + 514+514+521+521)/5 = 517s = 8m37s
This PR: (514 + 511 + 512+510+544)/5 = 518s = 8m38s
Kubernetes (compared to 12c156a)
Master: (66 + 65 + 65 + 60 + 62) / 5 = 63.6s
This PR: (60 + 59 + 62 + 58 + 58) / 5 = 59.4s (-4.2s)
Exec on existing cluster
Kubernetes (compared to 12c156a)
Master: (11.89 + 12.36 + 11.77 + 12.42 + 12.27) / 5 = 12.14s
This PR: (9.87 + 9.44 + 9.07 + 9.78 + 9.49) / 5 = 9.53s (-2.61s)
Launching new cluster with file mounts
for i in `seq 1 5`; do sky launch -y -c test-dep-$i --cloud gcp --cpus 2 task.yaml; done
Master: (147 + 124 + 149 + 150 + 147) / 5 = 143.5s = 2m23.5s
This PR: (145 + 140 + 139 + 142+153)/5 = 143.8s = 2m23.8s
Launching on an existing cluster
Master: (41+40+40+40+51)/5 = 42.4s
This PR: (39+38+37+37+38)/5 = 37.8s (-4.6s)
Exec on an existing cluster
Master: (8+6+7+7+7)/5 = 7s
This PR: (6+7+6+6+6)/5 = 6.2s (-0.8s)
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh