-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Faster optimizer table by disabling reservation check #3280
Merged
Michaelvll
merged 9 commits into
master
from
faster-optimizer-table-by-disabling-reservation-check
Mar 7, 2024
Merged
[Core] Faster optimizer table by disabling reservation check #3280
Michaelvll
merged 9 commits into
master
from
faster-optimizer-table-by-disabling-reservation-check
Mar 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-optimizer-table-by-disabling-reservation-check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, seeing >2x speedup on my end too.
Master
sky launch:
5.59, 3.84, 5.64
sky launch --gpus H100:8
3.19, 3.03, 3.17
#3280
sky launch:
2.38, 2.62, 2.21
sky launch --gpus H100:8
1.75, 1.41, 1.44
Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>
Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>
concretevitamin
approved these changes
Mar 7, 2024
Michaelvll
deleted the
faster-optimizer-table-by-disabling-reservation-check
branch
March 7, 2024 23:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #3159
Upper current PR, lower master (1.8s -> 0.5s): the time it takes for starting
_launch_with_confirm
to confirmation prompt.On my local laptop, it takes even longer: 127s vs 2s
Upper master, lower currnet PR
The reservation check on GCP causes the optimizer table to show up very slowly. We now disable the check by default, and add a new option to turn on it.
This issue becomes significant when H100 is involved (#3279, need to confirm)
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh