Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP] fix application key upload #3234

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

Michaelvll
Copy link
Collaborator

Our previous way for ignoring the application key is problemetic, as we will raise a FileNotFoundError when calling self._find_application_key_path() and the key file is not found, i.e., the later if os.path.exists(os.path.expanduser(application_key_path)): does not help for ignoring the credential file.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@Michaelvll Michaelvll merged commit 097aceb into master Feb 26, 2024
19 checks passed
@Michaelvll Michaelvll deleted the fix-gcp-credential-mount branch February 26, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants